Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Merge java/python/nodejs setup into Setup CI #2675

Closed
wants to merge 2 commits into from
Closed

ci: Merge java/python/nodejs setup into Setup CI #2675

wants to merge 2 commits into from

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jul 20, 2023

No description provided.

@Xuanwo
fix
0282bb0 
Signed-off-by: Xuanwo <[email protected]>
suyanhanx
suyanhanx reviewed Jul 20, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😥Merging them may not be a necessary thing. I think it's better to just keep configurations of core in setup action.

.github/workflows/docs.yml Show resolved Hide resolved
@Xuanwo
Copy link
Member Author

Xuanwo commented Jul 20, 2023

disappointed_relievedMerging them may not be a necessary thing. I think it's better to just keep configurations of core in setup action.

Yep, seems not worth it.

@Xuanwo Xuanwo closed this Jul 20, 2023
@Xuanwo Xuanwo deleted the refactor-ci branch July 20, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suyanhanx suyanhanx suyanhanx left review comments

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

@silver-ymz silver-ymz Awaiting requested review from silver-ymz

@xyjixyjixyji xyjixyjixyji Awaiting requested review from xyjixyjixyji

Assignees
No one assigned
Labels
releases-note/ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xuanwo @suyanhanx