Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(services/s3): Add assume role support #2687

Merged
merged 1 commit into from
Jul 23, 2023
Merged

feat(services/s3): Add assume role support #2687

merged 1 commit into from
Jul 23, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jul 23, 2023

I know this PR is complex, but this is how AWS works.

@Xuanwo Xuanwo requested a review from PsiACE as a code owner July 23, 2023 08:07
@Xuanwo Xuanwo requested review from suyanhanx and ClSlaid July 23, 2023 08:21
suyanhanx
suyanhanx approved these changes Jul 23, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@suyanhanx
Copy link
Member

May we add a test job for it?

@Xuanwo Xuanwo merged commit 8b9aef1 into main Jul 23, 2023
31 checks passed
@Xuanwo Xuanwo deleted the feat-assume-role branch July 23, 2023 08:23
This was referenced Jul 23, 2023
Closed
Closed
@Xuanwo
Copy link
Member Author

Xuanwo commented Jul 23, 2023

May we add a test job for it?

Tracked at #2690

@oowl oowl mentioned this pull request Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suyanhanx suyanhanx suyanhanx approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xuanwo @suyanhanx