Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(services/s3): Check header first for region detect #2691

Merged
merged 3 commits into from
Jul 23, 2023
Merged

refactor(services/s3): Check header first for region detect #2691

merged 3 commits into from
Jul 23, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jul 23, 2023

No description provided.

@Xuanwo Xuanwo requested review from suyanhanx and ClSlaid July 23, 2023 08:30
@Xuanwo
Fix typo
ba16c9c 
Signed-off-by: Xuanwo <[email protected]>
suyanhanx
suyanhanx approved these changes Jul 23, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's wating for ci green.

@Xuanwo Xuanwo marked this pull request as draft July 23, 2023 08:42
@Xuanwo
Polish API
34b6916 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo marked this pull request as ready for review July 23, 2023 08:43
@Xuanwo Xuanwo requested a review from PsiACE as a code owner July 23, 2023 08:43
@Xuanwo Xuanwo merged commit 3ecab57 into main Jul 23, 2023
30 checks passed
@Xuanwo Xuanwo deleted the polish-detect-region branch July 23, 2023 08:49
@oowl oowl mentioned this pull request Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suyanhanx suyanhanx suyanhanx approved these changes

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

Assignees
No one assigned
Labels
releases-note/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xuanwo @suyanhanx