feat(bindings/haskell): enhance original OpMonad to support custom IO monad
#2789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IO monad Signed-off-by: silver-ymz <[email protected]>
Signed-off-by: silver-ymz <[email protected]>
|
btw, why haskell's building is much slower than before? |
Signed-off-by: silver-ymz <[email protected]>
Signed-off-by: silver-ymz <[email protected]>
Haskell binding has lots of dependencies now, and ghc compiler is quiet slow. Could we use cache to speed up CI? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update:
OpMonadtoOperatorT, and add support for custom IO monadOperatorTis a monad transformer which keepsOperatorin its context. I think previous nameOpMonadis a little confused. AndOperatorTis more suitable for community naming rules, since there are some popular monad transformers named toReaderT,ExceptT, etc. So I renameOpMonadtoOperatorT.