Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fuzz test support read from .env by different services #2824

Merged
merged 4 commits into from
Aug 9, 2023
Merged

feat: fuzz test support read from .env by different services #2824

merged 4 commits into from
Aug 9, 2023

Conversation

dqhl76
Copy link
Member

@dqhl76 dqhl76 commented Aug 9, 2023

No description provided.

@dqhl76 dqhl76 requested a review from Xuanwo as a code owner August 9, 2023 03:18
@Xuanwo
Copy link
Member

Xuanwo commented Aug 9, 2023

Hi, why will we need to maintain those scripts in opendal repo?

@dqhl76
Copy link
Member Author

dqhl76 commented Aug 9, 2023 •
edited
Loading

Hi, why will we need to maintain those scripts in opendal repo?

I think it is more flexible. It is easier for us to add or remove fuzz targets.

If you think it is uneccesarry. Could you please give a review about that? I will remove it later and change that on oss-fuzz side

dqhl76
dqhl76 commented Aug 9, 2023
View reviewed changes
core/fuzz/utils.rs Outdated Show resolved Hide resolved
Xuanwo
Xuanwo reviewed Aug 9, 2023
View reviewed changes
core/fuzz/build.sh Outdated Show resolved Hide resolved
core/fuzz/utils.rs Outdated Show resolved Hide resolved
@dqhl76 dqhl76 changed the title chore: maintain oss-fuzz build script in opendal wip：maintain oss-fuzz build script in opendal Aug 9, 2023
@dqhl76
Copy link
Member Author

dqhl76 commented Aug 9, 2023 •
edited
Loading

case1:
file name: fuzz_reader
read .env

case2:
file name: fuzz_reader_{schema}
read .{schema}.env

case3:
file name: fuzz_reader_{schema}
read .{schema}.env -> not exist
read .env

@dqhl76 dqhl76 changed the title wip：maintain oss-fuzz build script in opendal feat: fuzz test support read from .env by different services Aug 9, 2023
@dqhl76
refact: use .schema.env
36e74a8 
fix: make clippy happy

Signed-off-by: dqhl76 <[email protected]>

rustfmt

Signed-off-by: dqhl76 <[email protected]>

refact: use .schema.env

Signed-off-by: dqhl76 <[email protected]>
@dqhl76 dqhl76 requested a review from Xuanwo August 9, 2023 05:24
Xuanwo
Xuanwo approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit ee34c9e into apache:main Aug 9, 2023
31 checks passed
@dqhl76 dqhl76 deleted the oss-fuzz-build branch August 9, 2023 05:54
This was referenced Aug 9, 2023
Merged
Closed
DavidKorczynski pushed a commit to google/oss-fuzz that referenced this pull request Aug 9, 2023
@dqhl76
opendal: fix environment problem (#10814)
226e1ac 
Fix the problem that opendal cannot init service
related PR on opendal side:
apache/opendal#2824
/cc @Xuanwo

---------

Signed-off-by: Liuqing Yue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/chore releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dqhl76 @Xuanwo