Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add retry for Writer::sink operation #2896

Merged
merged 1 commit into from
Aug 21, 2023
Merged

feat: Add retry for Writer::sink operation #2896

merged 1 commit into from
Aug 21, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Aug 21, 2023

This PR will add retry for sink operations.

@Xuanwo Xuanwo requested a review from PsiACE as a code owner August 21, 2023 15:14
@Xuanwo Xuanwo requested a review from suyanhanx August 21, 2023 15:16
suyanhanx
suyanhanx approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Xuanwo Xuanwo merged commit 8649189 into main Aug 21, 2023
79 of 80 checks passed
@Xuanwo Xuanwo deleted the retry-stream branch August 21, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suyanhanx suyanhanx suyanhanx approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xuanwo @suyanhanx