Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): add stat_with API for blocking operator #2915

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

oowl
Copy link
Member

@oowl oowl commented Aug 23, 2023

No description provided.

@oowl oowl requested a review from Xuanwo as a code owner August 23, 2023 14:37
@oowl
Copy link
Member Author

oowl commented Aug 23, 2023

@Xuanwo I found blocking operator has some API gap compared with the async operator, Maybe we need to fire a ticket to sync the operator and blocking operator API Semantics

@suyanhanx
Copy link
Member

What's the gap?

@oowl
Copy link
Member Author

oowl commented Aug 23, 2023

What's the gap?

For example FunctionWrite and FutureWrite, The functions of two should be the same, but in reality, there are differences between them. This is because we did not implement these APIs together.

https://github.com/apache/incubator-opendal/blob/main/core/src/types/operator/operator_futures.rs#L385

https://github.com/apache/incubator-opendal/blob/main/core/src/types/operator/operator_functions.rs#L78

@oowl oowl requested a review from suyanhanx August 23, 2023 14:51
@suyanhanx
Copy link
Member

suyanhanx commented Aug 23, 2023

You are right. We may need to check all of them and sync the test suites.

@Xuanwo
Copy link
Member

Xuanwo commented Aug 23, 2023

Maybe we need to fire a ticket to sync the operator and blocking operator API Semantics

Some API like sink are not implemented for blocking API. We can add them when we have those needs.

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit a39a526 into main Aug 23, 2023
85 checks passed
@Xuanwo Xuanwo deleted the feat/blocking-operator-stat-with branch August 23, 2023 15:17
@oowl
Copy link
Member Author

oowl commented Aug 24, 2023

@Xuanwo I found blocking operator has some API gap compared with the async operator, Maybe we need to fire a ticket to sync the operator and blocking operator API Semantics

#2924

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants