Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add benchmark for buf write #2922

Merged
merged 3 commits into from
Aug 24, 2023
Merged

feat: Add benchmark for buf write #2922

merged 3 commits into from
Aug 24, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Aug 24, 2023

at_least_buf_write/4.00 KiB
                        time:   [149.96 ns 150.10 ns 150.25 ns]
                        thrpt:  [25.388 GiB/s 25.415 GiB/s 25.438 GiB/s]
at_least_buf_write/256 KiB
                        time:   [127.08 ns 127.17 ns 127.28 ns]
                        thrpt:  [1918.2 GiB/s 1919.8 GiB/s 1921.2 GiB/s]
at_least_buf_write/4.00 MiB
                        time:   [124.63 ns 125.06 ns 125.72 ns]
                        thrpt:  [ 31072 GiB/s  31234 GiB/s  31342 GiB/s]
at_least_buf_write/16.0 MiB
                        time:   [125.82 ns 126.05 ns 126.34 ns]
                        thrpt:  [123677 GiB/s 123955 GiB/s 124186 GiB/s]

exact_buf_write/4.00 KiB
                        time:   [245.48 ns 245.68 ns 245.88 ns]
                        thrpt:  [15.515 GiB/s 15.527 GiB/s 15.540 GiB/s]
exact_buf_write/256 KiB time:   [215.33 ns 215.43 ns 215.53 ns]
                        thrpt:  [1132.7 GiB/s 1133.3 GiB/s 1133.8 GiB/s]
exact_buf_write/4.00 MiB
                        time:   [1.6147 µs 1.6155 µs 1.6163 µs]
                        thrpt:  [2416.8 GiB/s 2418.0 GiB/s 2419.2 GiB/s]
exact_buf_write/16.0 MiB
                        time:   [5.9971 µs 6.0011 µs 6.0048 µs]
                        thrpt:  [2602.1 GiB/s 2603.7 GiB/s 2605.4 GiB/s]

exact_buf_write is slower than at_least_buf_write which is expected since we need to make sure all write operation has been aligned with buffer size. Although I'm sure that there are many areas for improvement.

Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@suyanhanx
Copy link
Member

Is there any result?

@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 24, 2023

Is there any result?

updated.

Signed-off-by: Xuanwo <[email protected]>
@dqhl76
Copy link
Member

dqhl76 commented Aug 24, 2023

Do we need add a README under benches/oio or combine it with benches/ops?

@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 24, 2023

Do we need add a README under benches/oio or combine it with benches/ops?

I'm guessing read benches/README.md is enough. But It's Ok to improve them if you are intereted.

@dqhl76
Copy link
Member

dqhl76 commented Aug 24, 2023

Do we need add a README under benches/oio or combine it with benches/ops?

I'm guessing read benches/README.md is enough.

Ok.

Copy link
Member

@dqhl76 dqhl76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 1bb977b into main Aug 24, 2023
79 checks passed
@Xuanwo Xuanwo deleted the bench-exact-buf branch August 24, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants