Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(binding/java): Enable release build only when releasing #3057

Merged
merged 8 commits into from
Sep 13, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Sep 13, 2023

No description provided.

Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me prepare a patch for this issue. We can use an argument over env var, which is how we currently work.

@Xuanwo
Copy link
Member Author

Xuanwo commented Sep 13, 2023

Let me prepare a patch for this issue. We can use an argument over env var, which is how we currently work.

You can push to this branch directly.

@Xuanwo
Copy link
Member Author

Xuanwo commented Sep 13, 2023

Ok, I know the root cause: we are building rocksdb.

@Xuanwo
Copy link
Member Author

Xuanwo commented Sep 13, 2023

I will split the php related logic to a new PR.

@tisonkun
Copy link
Member

Ok, I know the root cause: we are building rocksdb.

If so, perhaps --release or not doesn't make too many changes?

@Xuanwo
Copy link
Member Author

Xuanwo commented Sep 13, 2023

If so, perhaps --release or not doesn't make too many changes?

Maybe not as good as I expected, but will be faster.

@tisonkun
Copy link
Member

OK. Ping me when you factor out the PHP changes. I'll push my solution on this branch then.

@Xuanwo
Copy link
Member Author

Xuanwo commented Sep 13, 2023

OK. Ping me when you factor out the PHP changes. I'll push my solution on this branch then.

#3058

@Xuanwo
Copy link
Member Author

Xuanwo commented Sep 13, 2023

On linux 22m -> 15m (alought it's failed for wrong dylib path)

@tisonkun tisonkun merged commit aad56c4 into main Sep 13, 2023
24 checks passed
@tisonkun tisonkun deleted the improve-java-ci branch September 13, 2023 17:46
@tisonkun tisonkun changed the title ci(binding/java): Enable release when OPENDAL_RELEASE is on ci(binding/java): Enable release build only when releasing Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants