-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(binding/java): Enable release build only when releasing #3057
Conversation
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me prepare a patch for this issue. We can use an argument over env var, which is how we currently work.
You can push to this branch directly. |
Ok, I know the root cause: we are building rocksdb. |
I will split the php related logic to a new PR. |
If so, perhaps |
Maybe not as good as I expected, but will be faster. |
OK. Ping me when you factor out the PHP changes. I'll push my solution on this branch then. |
|
On linux 22m -> 15m (alought it's failed for wrong dylib path) |
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
No description provided.