Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(services/s3): Detect region returned too early when header is empty #3187

Merged
merged 2 commits into from
Sep 26, 2023
Merged

fix(services/s3): Detect region returned too early when header is empty #3187

merged 2 commits into from
Sep 26, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Sep 26, 2023

No description provided.

@Xuanwo Xuanwo requested a review from PsiACE September 26, 2023 05:25
@Xuanwo Xuanwo requested review from dqhl76 and oowl September 26, 2023 05:40
dqhl76
dqhl76 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@dqhl76 dqhl76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@Xuanwo Xuanwo merged commit d5990fe into main Sep 26, 2023
43 checks passed
@Xuanwo Xuanwo deleted the fix-detect-region branch September 26, 2023 05:46
@suyanhanx suyanhanx mentioned this pull request Oct 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dqhl76 dqhl76 dqhl76 approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@suyanhanx suyanhanx Awaiting requested review from suyanhanx

@silver-ymz silver-ymz Awaiting requested review from silver-ymz

@oowl oowl Awaiting requested review from oowl

Assignees
No one assigned
Labels
releases-note/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xuanwo @dqhl76