feat(services/persy): change blocking_x in async_x call to tokio::task::blocking_spawn #3221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Sep 30, 2023
Zheaoli
force-pushed
the
manjusaka/persy-spawn
branch
from
3dbd390
to
582f1dc
Compare
oowl
reviewed
Sep 30, 2023
|
I will split the error refactor into a single pr. This PR would be drafted first. |
Zheaoli
force-pushed
the
manjusaka/persy-spawn
branch
3 times, most recently
from
7d84e5d
to
74bffc0
Compare
…k::blocking_spawn Signed-off-by: Manjusaka <[email protected]>
Zheaoli
force-pushed
the
manjusaka/persy-spawn
branch
from
74bffc0
to
ba8ae00
Compare
Signed-off-by: Manjusaka <[email protected]>
Signed-off-by: Manjusaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Manjusaka [email protected]