Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(services/gdrive): Extract folder search logic #3234

Merged
merged 7 commits into from
Oct 16, 2023
Merged

refactor(services/gdrive): Extract folder search logic #3234

merged 7 commits into from
Oct 16, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Oct 7, 2023

No description provided.

suyanhanx
suyanhanx approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement.

@Xuanwo
Copy link
Member Author

Xuanwo commented Oct 7, 2023 •
edited
Loading

Maybe it's better to extract the path cache logic out of gdrive for better understanding and test. I reverted all changes to cache logic and leave them to another PR.

@Xuanwo
Copy link
Member Author

Xuanwo commented Oct 7, 2023

test_blocking_copy_file always failed in CI but can't reproduce locally, I'm digging.

@Xuanwo
Fix build
2304d3d 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Save work
026955f 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Save
6cb17ad 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo changed the title refactor(services/gdrive): Use moka instead of Arc<Mutex<HashMap>> refactor(services/gdrive): Extract folder search logic Oct 16, 2023
@Xuanwo
Fix test
1d6588d 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Fix test
c38deb3 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Polish parent
eafc848 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Fix build
b35ca35 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo merged commit 9b9230c into main Oct 16, 2023
36 checks passed
@Xuanwo Xuanwo deleted the polish-gdrive branch October 16, 2023 08:52
@silver-ymz silver-ymz mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Young-Flash Young-Flash Young-Flash left review comments

@suyanhanx suyanhanx suyanhanx approved these changes

@ClSlaid ClSlaid ClSlaid approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

Assignees
No one assigned
Labels
releases-note/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Xuanwo @suyanhanx @ClSlaid @Young-Flash