Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(binding/java): make Metadata a POJO #3277

Merged
merged 7 commits into from
Oct 14, 2023
Merged

feat(binding/java): make Metadata a POJO #3277

merged 7 commits into from
Oct 14, 2023

Conversation

G-XD
Copy link
Contributor

@G-XD G-XD commented Oct 13, 2023

Make Metadata a POJO, preparing for support of list operations.

Related: #3169 (comment)

@G-XD G-XD requested a review from tisonkun as a code owner October 13, 2023 15:14
tisonkun
tisonkun reviewed Oct 14, 2023
View reviewed changes
bindings/java/src/lib.rs Outdated Show resolved Hide resolved
tisonkun
tisonkun reviewed Oct 14, 2023
View reviewed changes
bindings/java/src/lib.rs Outdated Show resolved Hide resolved
Xuanwo
Xuanwo reviewed Oct 14, 2023
View reviewed changes
bindings/java/src/lib.rs Outdated Show resolved Hide resolved
tisonkun
tisonkun approved these changes Oct 14, 2023
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisonkun tisonkun merged commit 3108bd3 into apache:main Oct 14, 2023
49 checks passed
@tisonkun
Copy link
Member

Thank you!

@G-XD G-XD deleted the java_binding_metadata branch October 14, 2023 15:20
@tisonkun tisonkun mentioned this pull request Oct 15, 2023
Merged
@silver-ymz silver-ymz mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo left review comments

@tisonkun tisonkun tisonkun approved these changes

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@G-XD @tisonkun @Xuanwo