Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(services/rocksdb): change blocking_x in async_x call to tokio::task::blocking_spawn #3279

Merged
merged 3 commits into from
Oct 14, 2023
Merged

feat(services/rocksdb): change blocking_x in async_x call to tokio::task::blocking_spawn #3279

merged 3 commits into from
Oct 14, 2023

Conversation

shauvet
Copy link
Contributor

@shauvet shauvet commented Oct 14, 2023

feat(services/rocksdb): change blocking_x in async_x call to tokio::task::blocking_spawn

@shauvet shauvet requested a review from Xuanwo as a code owner October 14, 2023 01:58
@shauvet
Copy link
Contributor Author

shauvet commented Oct 14, 2023

Should I pay attention to this error:
Error: Error: API rate limit exceeded for 40.86.168.192. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)

@Xuanwo
Copy link
Member

Xuanwo commented Oct 14, 2023

Should I pay attention to this error:

Error: Error: API rate limit exceeded for 40.86.168.192. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)

You can ignore this error safely.

Xuanwo
Xuanwo approved these changes Oct 14, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit c5ea00a into apache:main Oct 14, 2023
37 checks passed
@silver-ymz silver-ymz mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shauvet @Xuanwo