Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(bindings/java): move out convert fns #3389

Merged
merged 1 commit into from
Oct 26, 2023
Merged

chore(bindings/java): move out convert fns #3389

merged 1 commit into from
Oct 26, 2023
+102 −65

Conversation

tisonkun
Copy link
Member

Keep lib.rs slim.

@tisonkun tisonkun requested review from Xuanwo and G-XD October 26, 2023 11:23
suyanhanx
suyanhanx approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@tisonkun tisonkun merged commit 2e7a171 into apache:main Oct 26, 2023
45 checks passed
@tisonkun tisonkun deleted the moveoutconvert branch October 26, 2023 12:30
@silver-ymz silver-ymz mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suyanhanx suyanhanx suyanhanx approved these changes

@Xuanwo Xuanwo Awaiting requested review from Xuanwo

@G-XD G-XD Awaiting requested review from G-XD

Assignees
No one assigned
Labels
releases-note/chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tisonkun @suyanhanx