fix(services/s3): Accept List responses without ETag #3478
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the S3 logic to accept response for path listings that don't contain the optional
<ETag>
xml element.The bug was originally observed when connecting to an S3 compatible server:
s3s-fs
(https://crates.io/crates/s3s-fs).I believe s3s-fs's behaviour is correct, given that the AWS S3 request/response docs state that the
Etag
field is optional: https://docs.aws.amazon.com/AmazonS3/latest/API/API_Object.html.Closes #3477.