Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bindings/python): fix type annotations and improve docs #3483

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

messense
Copy link
Member

@messense messense commented Nov 4, 2023

| syntax for union type is only supported on Python 3.10+.

Also formatted code with Black, the change is minimal so doesn't seem to worth a separate PR.

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit d27dc3e into apache:main Nov 4, 2023
51 checks passed
@messense messense deleted the improve-py-typing-docs branch November 4, 2023 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants