Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(services/azblob): add AzblobConfig #3553

Merged
merged 3 commits into from
Nov 11, 2023
Merged

refactor(services/azblob): add AzblobConfig #3553

merged 3 commits into from
Nov 11, 2023

Conversation

acehinnnqru
Copy link
Contributor

Impl Azblob support for #3240 .

Xuanwo
Xuanwo reviewed Nov 10, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also implement from_map based on AzblobConfig

core/src/services/azblob/backend.rs Show resolved Hide resolved
core/src/services/azblob/backend.rs Outdated Show resolved Hide resolved
Xuanwo
Xuanwo approved these changes Nov 11, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 5dfc3c2 into apache:main Nov 11, 2023
35 checks passed
@G-XD G-XD mentioned this pull request Nov 27, 2023
Merged
@suyanhanx suyanhanx mentioned this pull request Dec 22, 2023
Closed
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acehinnnqru @Xuanwo