Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(service): alluxio support write #3566

Merged
merged 1 commit into from
Nov 14, 2023
Merged

feat(service): alluxio support write #3566

merged 1 commit into from
Nov 14, 2023

Conversation

hoslo
Copy link
Contributor

@hoslo hoslo commented Nov 12, 2023

feat #3548

@hoslo hoslo requested a review from Xuanwo as a code owner November 12, 2023 06:45
@Xuanwo
Copy link
Member

Xuanwo commented Nov 12, 2023

Hi, how about adding test first so that we can test our changes on solid base instead?

@hoslo
Copy link
Contributor Author

hoslo commented Nov 12, 2023

Hi, how about adding test first so that we can test our changes on solid base instead?

of course, Where should I start?

@Xuanwo
Copy link
Member

Xuanwo commented Nov 12, 2023

of course, Where should I start?

You can take #3493 as reference. Basicly, we need to add a docker-compose file to allow developers to setup test env, and than, we need to add this setup in CI workflow.

@hoslo
Copy link
Contributor Author

hoslo commented Nov 12, 2023

of course, Where should I start?

You can take #3493 as reference. Basicly, we need to add a docker-compose file to allow developers to setup test env, and than, we need to add this setup in CI workflow.

Should I add it in this pr or another?

@Xuanwo
Copy link
Member

Xuanwo commented Nov 12, 2023

Should I add it in this pr or another?

We can start a new PR for this and return to this PR later.

@hoslo
Copy link
Contributor Author

hoslo commented Nov 14, 2023

Should I add it in this pr or another?

We can start a new PR for this and return to this PR later.

can you review this pr?

Xuanwo
Xuanwo reviewed Nov 14, 2023
View reviewed changes
core/src/services/alluxio/backend.rs Show resolved Hide resolved
core/src/services/alluxio/writer.rs Outdated Show resolved Hide resolved
Xuanwo
Xuanwo approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot!

@Xuanwo Xuanwo merged commit b908c66 into apache:main Nov 14, 2023
35 checks passed
@hoslo hoslo deleted the alluxio-support-write branch November 27, 2023 06:03
@G-XD G-XD mentioned this pull request Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoslo @Xuanwo