Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Concurrent Stat in List #3574

Merged
merged 6 commits into from
Nov 15, 2023
Merged

RFC: Concurrent Stat in List #3574

merged 6 commits into from
Nov 15, 2023

Conversation

morristai
Copy link
Member

@morristai morristai commented Nov 13, 2023 •
edited
Loading

Description

relate: #3097

@Xuanwo Xuanwo changed the title feat(RFC): add concurrent stat in list RFC: Concurrent Stat in List Nov 13, 2023
@morristai morristai mentioned this pull request Nov 13, 2023
Closed
Xuanwo
Xuanwo reviewed Nov 15, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM! Thanks for carrying the RFC.

core/src/docs/rfcs/3574_concurrent_stat_in_list.md Outdated Show resolved Hide resolved
@Xuanwo
Copy link
Member

Xuanwo commented Nov 15, 2023

Inviting more committers to review the RFC.

oowl
oowl approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@oowl oowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

suyanhanx
suyanhanx approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@Xuanwo Xuanwo merged commit b4a2221 into apache:main Nov 15, 2023
149 checks passed
dqhl76
dqhl76 approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@dqhl76 dqhl76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@morristai morristai deleted the feat/rfc_for_concurrent_stat_in_list branch November 16, 2023 06:07
@G-XD G-XD mentioned this pull request Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@suyanhanx suyanhanx suyanhanx approved these changes

@oowl oowl oowl approved these changes

@dqhl76 dqhl76 dqhl76 approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@morristai @Xuanwo @suyanhanx @oowl @dqhl76