Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(service): support b2 #3604

Merged
merged 1 commit into from
Nov 21, 2023
Merged

feat(service): support b2 #3604

merged 1 commit into from
Nov 21, 2023

Conversation

hoslo
Copy link
Contributor

@hoslo hoslo commented Nov 17, 2023 •
edited
Loading

Part #3585

@hoslo
Copy link
Contributor Author

hoslo commented Nov 17, 2023

I've already run the tests locally

Xuanwo
Xuanwo reviewed Nov 17, 2023
View reviewed changes
core/src/services/b2/backend.rs Outdated Show resolved Hide resolved
core/src/services/b2/backend.rs Outdated Show resolved Hide resolved
core/src/services/b2/backend.rs Show resolved Hide resolved
core/src/services/b2/backend.rs Outdated Show resolved Hide resolved
core/src/services/b2/backend.rs Outdated Show resolved Hide resolved
core/src/services/b2/backend.rs Show resolved Hide resolved
core/src/services/b2/backend.rs Outdated Show resolved Hide resolved
core/src/services/b2/core.rs Outdated Show resolved Hide resolved
core/src/services/b2/writer.rs Outdated Show resolved Hide resolved
core/src/services/b2/writer.rs Outdated Show resolved Hide resolved
Xuanwo
Xuanwo reviewed Nov 20, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, great work!

core/src/services/b2/backend.rs Show resolved Hide resolved
core/src/services/b2/backend.rs Outdated Show resolved Hide resolved
Xuanwo
Xuanwo reviewed Nov 21, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, only some small typo. We are nearly good to go!

.env.example Outdated Show resolved Hide resolved
Cargo.lock Outdated Show resolved Hide resolved
core/src/services/b2/writer.rs Outdated Show resolved Hide resolved
Xuanwo
Xuanwo approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, let's go!

@Xuanwo Xuanwo mentioned this pull request Nov 21, 2023
Closed
@Xuanwo Xuanwo merged commit 26b52cc into apache:main Nov 21, 2023
168 of 169 checks passed
@hoslo hoslo deleted the support-b2 branch November 27, 2023 06:03
@G-XD G-XD mentioned this pull request Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoslo @Xuanwo