feat(bindings/nodejs): read/write stream #3619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are too many irrelevant tests being started? |
|
Need to add |
|
Seems we need to add capability support first? |
Yes. I'm going to add it first. |
suyanhanx
changed the title
suyanhanx
force-pushed
the
nodejs-stream
branch
from
1207822
to
5074658
Compare
Xuanwo
reviewed
Nov 24, 2023
suyanhanx
force-pushed
the
nodejs-stream
branch
from
7c781e0
to
b522f1b
Compare
suyanhanx
changed the title
|
Invite @everpcpc to take a look. |
|
lgtm, thanks! |
18 tasks
Xuanwo
reviewed
Nov 27, 2023
Xuanwo
reviewed
Nov 27, 2023
Signed-off-by: suyanhanx <[email protected]>
suyanhanx
force-pushed
the
nodejs-stream
branch
from
5c67df8
to
ffedefe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the reader and writer, and readable/writable stream based on them.