Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(binding/java): fix SPECIAL_DIR_NAME #3715

Merged
merged 1 commit into from
Dec 6, 2023
Merged

fix(binding/java): fix SPECIAL_DIR_NAME #3715

merged 1 commit into from
Dec 6, 2023

Conversation

G-XD
Copy link
Contributor

@G-XD G-XD commented Dec 6, 2023

related: #3712 (comment)

@G-XD G-XD requested a review from tisonkun as a code owner December 6, 2023 07:40
tisonkun
tisonkun approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. How we introduce the inconsistency at the first place? I saw the Rust test cases do not have this issue ever.

@Xuanwo Xuanwo changed the title test(binding/java): fix SPECIAL_DIR_NAME fix(binding/java): fix SPECIAL_DIR_NAME Dec 6, 2023
@Xuanwo
Copy link
Member

Xuanwo commented Dec 6, 2023

OBS failed to insufficient balance, let's ignore for now.

@Xuanwo Xuanwo merged commit b721309 into main Dec 6, 2023
54 of 69 checks passed
@Xuanwo Xuanwo deleted the fix_java_test branch December 6, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

Assignees
No one assigned
Labels
releases-note/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@G-XD @Xuanwo @tisonkun