Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Deploy website to nightlies for every tags #3739

Merged
merged 2 commits into from
Dec 12, 2023
Merged

docs: Deploy website to nightlies for every tags #3739

merged 2 commits into from
Dec 12, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Dec 11, 2023

Part of #3319

We still need some frontend work, but I think it should not be a blocker.

@Xuanwo Xuanwo requested a review from PsiACE as a code owner December 11, 2023 08:03
@suyanhanx
Copy link
Member

Thank you for submitting this PR!
Indeed, there are some changes needed in the frontend code.
Currently, the generated dist cannot be deployed directly to a different path.
However, I have no objections to merging this PR. I will make further modifications later on.

@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 11, 2023

Currently, the generated dist cannot be deployed directly to a different path.
However, I have no objections to merging this PR. I will make further modifications later on.

Thanks! We can fix them before next release.

@Xuanwo Xuanwo mentioned this pull request Dec 11, 2023
Closed
1 task
@Xuanwo
Add deploy to stable
707caba 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 12, 2023

cc @tisonkun, JIRA ticket has been fixed. PTAL.

tisonkun
tisonkun approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give it a try.

@Xuanwo Xuanwo merged commit fd6db0c into main Dec 12, 2023
183 checks passed
@Xuanwo Xuanwo deleted the versionize-docs branch December 12, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

@suyanhanx suyanhanx Awaiting requested review from suyanhanx

Assignees
No one assigned
Labels
releases-note/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xuanwo @suyanhanx @tisonkun