Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(bindings/ocaml): dep opendal point to core #3814

Merged
merged 1 commit into from
Dec 24, 2023
Merged

chore(bindings/ocaml): dep opendal point to core #3814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions bindings/ocaml/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion bindings/ocaml/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ doc = false

[dependencies]
ocaml = { version = "^1.0.0-beta" }
opendal = "0.43.0"
opendal = { path = "../../core" }

[build-dependencies]
ocaml-build = { version = "^1.0.0-beta" }
8 changes: 4 additions & 4 deletions bindings/ocaml/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ apt-get install opam
#### Init OPAM
*Do not put sudo in front of any opam commands. That would break your OCaml installation.*

After Install OPAM, we need initialize it
After Installing OPAM, we need to initialize it

For the general case, we can execute
```bash
Expand All @@ -47,7 +47,7 @@ opam init --bare -a -y --disable-sandboxing


#### Create OPAM Switch
Using opam we can have multiple versions of ocaml at the same time, this is called switch.
Using opam, we can have multiple versions of ocaml at the same time; this is called switch.

Due to the upstream `ocaml-rs`, we currently do not support OCaml5, and recommend using the latest version of OCaml4
We can create use this command:
Expand All @@ -59,8 +59,8 @@ eval $(opam env)
```
#### Install OPAM Package

opendal does not depend on opam package except `ounit2` for testing.
However, in order to facilitate development in an IDE such as vscode, it is usually necessary to install the following content
OpenDAL does not depend on opam package except `ounit2` for testing.
However, to facilitate development in an IDE such as vscode, it is usually necessary to install the following content
```bash
opam install -y utop odoc ounit2 ocaml-lsp-server ocamlformat ocamlformat-rpc
```
Expand Down