Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): List root should not return itself #3824

Merged
merged 4 commits into from
Dec 26, 2023
Merged

fix(core): List root should not return itself #3824

merged 4 commits into from
Dec 26, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Dec 26, 2023 •
edited
Loading

close #3822

@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 26, 2023

I will address this issue first. The tests seems broken.

@Xuanwo Xuanwo changed the title fix: List root should not return itself fix(cire): List root should not return itself Dec 26, 2023
@Xuanwo Xuanwo changed the title fix(cire): List root should not return itself fix(core): List root should not return itself Dec 26, 2023
suyanhanx
suyanhanx approved these changes Dec 26, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Xuanwo Xuanwo merged commit 09b0672 into main Dec 26, 2023
70 of 71 checks passed
@Xuanwo Xuanwo deleted the fix-list-root branch December 26, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suyanhanx suyanhanx suyanhanx approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@dqhl76 dqhl76 Awaiting requested review from dqhl76

Assignees
No one assigned
Labels
releases-note/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List on s3 could return empty entry
2 participants
@Xuanwo @suyanhanx