Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding Atomicserver config #3845

Merged
merged 2 commits into from
Dec 28, 2023
Merged

feat: Adding Atomicserver config #3845

merged 2 commits into from
Dec 28, 2023

Conversation

k-aishwarya
Copy link
Contributor

For #3240
@Xuanwo Please review

Xuanwo
Xuanwo reviewed Dec 28, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other LGTM, great work!

core/src/services/atomicserver/backend.rs Outdated Show resolved Hide resolved
@Xuanwo Xuanwo changed the title Adding Atimicserver config feat: Adding Atimicserver config Dec 28, 2023
@k-aishwarya k-aishwarya changed the title feat: Adding Atimicserver config feat: Adding Atomicserver config Dec 28, 2023
Xuanwo
Xuanwo approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 064c0bf into apache:main Dec 28, 2023
38 checks passed
This was referenced Dec 29, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-aishwarya @Xuanwo