Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(bindings/python): improve ASF branding #3850

Merged
merged 3 commits into from
Dec 29, 2023
Merged

chore(bindings/python): improve ASF branding #3850

merged 3 commits into from
Dec 29, 2023

Conversation

tisonkun
Copy link
Member

@tisonkun tisonkun commented Dec 29, 2023 •
edited
Loading

This closes #3848.

Potential improvement:

  • Better footer style (CSS)
  • If the logo gets changed to "Apache OpenDAL™" itself [1], we can change the nav_title refers to the logo.
image

@tisonkun tisonkun marked this pull request as draft December 29, 2023 03:35
@tisonkun tisonkun marked this pull request as ready for review December 29, 2023 03:38
Xuanwo
Xuanwo reviewed Dec 29, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other LGTM, thanks a lot!

bindings/python/template/module.html.jinja2 Show resolved Hide resolved
@tisonkun
license header
4c34f3d 
Signed-off-by: tison <[email protected]>
Xuanwo
Xuanwo approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit f2559fe into apache:main Dec 29, 2023
32 checks passed
@Xuanwo Xuanwo mentioned this pull request Dec 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@messense messense Awaiting requested review from messense messense is a code owner

@Zheaoli Zheaoli Awaiting requested review from Zheaoli Zheaoli is a code owner

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

Assignees
No one assigned
Labels
releases-note/chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Customize pdoc template to include the ASF branding footer like other website page
2 participants
@tisonkun @Xuanwo