Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(services/etcd): Impl parse_error instead of From<Error> #3910

Merged
merged 2 commits into from
Jan 4, 2024
Merged

refactor(services/etcd): Impl parse_error instead of From<Error> #3910

merged 2 commits into from
Jan 4, 2024

Conversation

suyanhanx
Copy link
Member

@suyanhanx suyanhanx commented Jan 4, 2024 •
edited
Loading

part of #3844

@suyanhanx suyanhanx requested a review from Xuanwo as a code owner January 4, 2024 09:59
@Xuanwo
Copy link
Member

Xuanwo commented Jan 4, 2024

Although the purpose of this PR is quite clear, could you please add some references in the description?

@suyanhanx
extract conn
c0df1a3 
Signed-off-by: suyanhanx <[email protected]>
@suyanhanx suyanhanx mentioned this pull request Jan 4, 2024
Closed
5 tasks
@suyanhanx
Copy link
Member Author

suyanhanx commented Jan 4, 2024 •
edited
Loading

Although the purpose of this PR is quite clear, could you please add some references in the description?

I see. You update the last PR for this issue, too. Thanks.

Xuanwo
Xuanwo approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 6d82c2d into main Jan 4, 2024
41 checks passed
@Xuanwo Xuanwo deleted the etcd-error branch January 4, 2024 10:23
@Zheaoli Zheaoli mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suyanhanx @Xuanwo