Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Format code to make readers happy #3912

Merged
merged 2 commits into from
Jan 4, 2024
Merged

chore: Format code to make readers happy #3912

merged 2 commits into from
Jan 4, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jan 4, 2024

No description provided.

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can we prevent formatting forth and back?

Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Xuanwo
Copy link
Member Author

Xuanwo commented Jan 4, 2024

How can we prevent formatting forth and back?

No back-and-forth occurred here; all code follows the same format style as described in rustfmt.toml. The changes in this PR were introduced by new formatting rules available only in nightly Rust.

We will enable them once they are stabilized.


I manually rearranged the method order for impl Accessor.

@Xuanwo Xuanwo merged commit 45270f8 into main Jan 4, 2024
170 of 234 checks passed
@Xuanwo Xuanwo deleted the format_code branch January 4, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants