docs: improve user verify words #3941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <[email protected]>
suyanhanx
reviewed
Jan 8, 2024
|
Sorry, but I think the proposal will make it harder for the end user, as they would have to read another page. The current page makes clear that verification is expected; that would be lost. Why not use the text I suggested in the incubator thread? |
This reverts commit 6373ae1.
Signed-off-by: tison <[email protected]>
tisonkun
changed the title
|
@sebbASF I get your point now. Update the sentence following your suggestion. |
sebbASF
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait a bit for @sebbASF's comment. I'm not a native speaker and this is something matters about wording.
The description is copied from https://flink.apache.org/downloads/#verifying-hashes-and-signatures.