Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: precise footer #3997

Merged
merged 4 commits into from
Jan 17, 2024
Merged

chore: precise footer #3997

merged 4 commits into from
Jan 17, 2024

Conversation

tisonkun
Copy link
Member

@tisonkun tisonkun commented Jan 16, 2024

It seems we don't use logo and Apache Incubator name in these bunches of page.

Please double check the changes and if my understanding is proper instead of blindly merge this.

Copy link
Member

@Zheaoli Zheaoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisonkun
Copy link
Member Author

Seems I should run the peritter. I prepare this patch on mobile phone, so let me fix it tomorrow morning.

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tisonkun tisonkun requested a review from PsiACE as a code owner January 17, 2024 00:45
@tisonkun tisonkun merged commit 553cb35 into main Jan 17, 2024
152 checks passed
@tisonkun tisonkun deleted the tisonkun-patch-1 branch January 17, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants