fix(examples/cpp): display the results to standard output. #4040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dqhl76
reviewed
Jan 21, 2024
| @@ -22,4 +22,5 @@ int main() { | |||
| opendal::ReaderStream stream(reader); | |||
| std::string res2; | |||
| stream >> res2; // res2 == "abc" | |||
| std::cout<<res2<<std::endl; | |||
There was a problem hiding this comment.
We have a comment on the last line to show the result.
// res2 == "abc"
I think it's not necessary to add an additional line for displaying this result to the standard output.
There was a problem hiding this comment.
yes, I noticed the comment. But for a newbie，when he run a program, there is no any outputs and the program terminated. This seems a little strange. So I think print the result is better.
|
Our cpp example is so simple that doesn't meet realistic use cases. Welcome to join in the improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.