Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bindings/ocaml): pinning OCaml binding opendal version for release #4086

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

Ranxy
Copy link
Contributor

@Ranxy Ranxy commented Jan 28, 2024

Ref #4057
In this issue we discussed the release issue of OCaml binding. One solution is the current PR.
In this PR, the version of opendal is fixed so that the core directory is not required when building, so that when releasing, we can package this binding code separately.
At the same time, this PR also tested the results of building different OCaml versions and modified the OCaml version restrictions.
After this PR is merged, release OCaml binding requires the following steps:

  1. During release, package bindings/ocaml separately into something similar to apache-opendal-$release_version-binding-ocaml-src.tar.gz, and create its sha512 hash.
  2. Copy the opendal.opam file in binding/ocaml and append the following code
url {
   src: "https://github.com/apache/opendal/path_to_ocaml_binding_code.tar.gz"
   checksum: [
"sha512=hash"
   ]
}
  1. Go to https://github.com/ocaml/opam-repository to submit a PR. The content is the opendal.opam file modified in the previous step.
  2. Wait for the PR to be merged after the ci of opam is passed.

@Xuanwo
Copy link
Member

Xuanwo commented Jan 28, 2024

After this PR is merged, release OCaml binding requires the following steps:

How about starting another issue to discuss the ocaml release process? We need to find way to make it integrate well with our ASF release.

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 519e6e1 into apache:main Jan 28, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants