feat(services/vercel_blob): support vercel blob #4103
Conversation
hoslo
force-pushed
the
support-vercel-blob
branch
from
7c12aef
to
f11dc24
Compare
|
@Xuanwo blob fails to pass the test of test_write_with_special_chars, after debugging, i feel that it is a vercel error. Maybe you can help me check it |
This test is not mentioned in the documentation. Perhaps we can simply ignore it for the Vercel blob. |
|
Sorry for the mistake operation |
hoslo
force-pushed
the
support-vercel-blob
branch
3 times, most recently
from
ea4f17d
to
410b9c0
Compare
|
Why does seafile container not start? |
|
Seems seafile pushed a new tag serval hours ago:
Maybe we can change the tag in docker-compose file to use the old one until they addressed. Would you like to submit a new PR for this? |
|
Fixed in #4107, please try again after merge with |
hoslo
force-pushed
the
support-vercel-blob
branch
2 times, most recently
from
5ba2571
to
c592c2c
Compare
hoslo
force-pushed
the
support-vercel-blob
branch
3 times, most recently
from
2707f5c
to
5fd43df
Compare
| return Err(Error::new(ErrorKind::NotFound, "Blob not found")); | ||
| } | ||
|
|
||
| // Use the first url to download the file |
| return Err(Error::new(ErrorKind::NotFound, "Blob not found")); | ||
| } | ||
|
|
||
| let url = &blobs[0].url; |
There was a problem hiding this comment.
The same here. The first blob returned in list might not be the blob we want.
There was a problem hiding this comment.
For example, we have files like aa. If users trying to get file a, they will got aa.
There was a problem hiding this comment.
My bad. It should have matched pathname, fixed.
| pub async fn copy(&self, from: &str, to: &str) -> Result<Response<IncomingAsyncBody>> { | ||
| let from = build_abs_path(&self.root, from); | ||
|
|
||
| let resp = self.list(&from, Some(1)).await?; |
There was a problem hiding this comment.
This pattern show a lot. Maybe we can add a function called resolve_blob? We can implement the get blob logic and leave detailed comments there.
|
|
||
| let status = resp.status(); | ||
|
|
||
| match status { |
There was a problem hiding this comment.
We can write like this to improvie the readability
if status != StatusCode::OK {
return Err(parse_error(resp).await?);
}
// other logic| // In this case, we want to create a new MPU. | ||
| req = req.header("x-mpu-action", "create"); | ||
|
|
||
| req = req.header("x-add-random-suffix", "0"); |
There was a problem hiding this comment.
These headers are used in multiple places. We can extract them as constants and add comments to explain their meaning and possible values.
hoslo
force-pushed
the
support-vercel-blob
branch
from
5fd43df
to
d981c28
Compare
hoslo
force-pushed
the
support-vercel-blob
branch
from
d981c28
to
b4dd17a
Compare
fixes #2191