Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(raw): Allow retrying request while decoding response failed #4612

Merged
merged 3 commits into from
May 14, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented May 14, 2024

We will treat decoding response errors as hard errors, but they are usually safe to retry, similar to connection resets.

Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo merged commit 1824d93 into main May 14, 2024
247 checks passed
@Xuanwo Xuanwo deleted the allow-retry-read-response-error branch May 14, 2024 09:59
George-Miao pushed a commit to George-Miao/opendal that referenced this pull request Jun 5, 2024
…he#4612)

* fix(raw): Allow retrying request while decoding response failed

Signed-off-by: Xuanwo <[email protected]>

* inline some code

Signed-off-by: Xuanwo <[email protected]>

* Polish code

Signed-off-by: Xuanwo <[email protected]>

---------

Signed-off-by: Xuanwo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants