fix(core/oio): Make ConcurrentTasks cancel safe by only pop after ready #4707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <[email protected]>
21 tasks
Signed-off-by: Xuanwo <[email protected]>
PsiACE
approved these changes
Jun 7, 2024
Xuanwo
added a commit
to Xuanwo/opendal
that referenced
this pull request
Jun 7, 2024
…dy (apache#4707) * fix(core/oio): Make ConcurrentTasks cancel safe by only pop after ready Signed-off-by: Xuanwo <[email protected]> * add part numbers check Signed-off-by: Xuanwo <[email protected]> --------- Signed-off-by: Xuanwo <[email protected]>
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConcurrentTasksis not cancel safe since it will change states when poll returns Pending. This PR fixed this by only pop task after it returns ready.