Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: impl put_multipart in object_store #4793

Merged
merged 7 commits into from
Aug 1, 2024
Merged

feat: impl put_multipart in object_store #4793

merged 7 commits into from
Aug 1, 2024

Conversation

Rachelint
Copy link
Contributor

@Rachelint Rachelint commented Jun 23, 2024 •
edited
Loading

close: #4748

@github-actions github-actions bot requested a review from ClSlaid June 23, 2024 17:50
@Rachelint
Copy link
Contributor Author

@Xuanwo hi, have a moment to review?

Xuanwo
Xuanwo reviewed Jun 24, 2024
View reviewed changes
integrations/object_store/src/store.rs Outdated Show resolved Hide resolved
integrations/object_store/src/store.rs Outdated Show resolved Hide resolved
integrations/object_store/src/store.rs Show resolved Hide resolved
@Rachelint Rachelint force-pushed the impl-put-multipart branch 2 times, most recently from 819fce4 to d4391e3 Compare June 24, 2024 16:51
@Xuanwo Xuanwo marked this pull request as draft June 26, 2024 07:06
@Xuanwo Xuanwo marked this pull request as ready for review August 1, 2024 08:36
@Xuanwo
Copy link
Member

Xuanwo commented Aug 1, 2024

Hi @Rachelint, thank you for your patience.

I attempted to address this issue through OpenDAL's API design but ultimately found it unfeasible, so I implemented a workaround using task notifications instead. The concurrent writing occurs within OpenDAL itself, so the lock here isn't a major concern.

@Xuanwo Xuanwo merged commit 84a4ce3 into apache:main Aug 1, 2024
207 checks passed
@Rachelint
Copy link
Contributor Author

I attempted to address this issue through OpenDAL's API design but ultimately found it unfeasible, so I implemented a workaround using task notifications instead. The concurrent writing occurs within OpenDAL itself, so the lock here isn't a major concern.

Thanks for @Xuanwo

ho-229 pushed a commit to ho-229/incubator-opendal that referenced this pull request Aug 6, 2024
@Rachelint @ho-229
feat: impl put_multipart in object_store (apache#4793)
79ef88a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

object_store: Implement put_multipart via Writer
2 participants
@Rachelint @Xuanwo