Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(nodejs)!: Remove append api #4796

Merged
merged 1 commit into from
Jun 24, 2024
Merged

refactor(nodejs)!: Remove append api #4796

merged 1 commit into from
Jun 24, 2024

Conversation

bxb100
Copy link
Contributor

@bxb100 bxb100 commented Jun 24, 2024

depends on: #4785

close: #4792

@github-actions github-actions bot requested review from ClSlaid and G-XD June 24, 2024 06:26
@Xuanwo Xuanwo changed the title refactor: Node remove append api refactor(nodejs)!: Remove append api Jun 24, 2024
Xuanwo
Xuanwo reviewed Jun 24, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, would you like to rebase your base branch so that we can avoid unrelated changes? Thanks.

bindings/nodejs/generated.d.ts Outdated Show resolved Hide resolved
Xuanwo
Xuanwo approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo marked this pull request as ready for review June 24, 2024 13:51
@Xuanwo Xuanwo requested a review from suyanhanx as a code owner June 24, 2024 13:51
@Xuanwo Xuanwo merged commit 363ba6d into apache:main Jun 24, 2024
57 checks passed
@bxb100 bxb100 mentioned this pull request Jun 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@G-XD G-XD Awaiting requested review from G-XD

@suyanhanx suyanhanx Awaiting requested review from suyanhanx suyanhanx is a code owner

Assignees
No one assigned
Labels
releases-note/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nodejs: Remove op.append API
2 participants
@bxb100 @Xuanwo