fix(core/services/onedrive): remove @odata.count for onedrive list op #4803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for the record, I verified this change locally on my branch 
end to end I don't think a local run of the behavior test is needed because this PR is deleting an unused field |
thanks for the quick review! 🫡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
@odata.countdoes not seem to exist before in their official docs...Recently I found they don't return this field anymore so all list op would raise errors.
I'm going to remove it.
In this repo, this field does not exist for all the time: https://github.com/sreeise/graph-rs-sdk/blob/afda1dcfbf5d491e56c6753152a1ce7e1c97fb44/test_files/drive_ep/drive_root_child.json#L4