Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce opendal AsyncWriter for parquet integrations #4958

Merged
merged 10 commits into from
Aug 5, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Aug 3, 2024

Which issue does this PR close?

part of #4868

Rationale for this change

Add parquet arrow async write support

What changes are included in this PR?

  1. Intorduce the parquet_opendal(integration/parquet) crate
  2. Implement the OpendalAsyncWriter

Are there any user-facing changes?

No

@WenyXu
Copy link
Member Author

WenyXu commented Aug 3, 2024

BTW, How can I generate a DEPENDENCIES.rust.tsv file, Are there any available docs? 👀

@PsiACE
Copy link
Member

PsiACE commented Aug 3, 2024

BTW, How can I generate a DEPENDENCIES.rust.tsv file, Are there any available docs? 👀

https://opendal.apache.org/community/release/#generate-dependencies-list

@Xuanwo
Copy link
Member

Xuanwo commented Aug 3, 2024

BTW, How can I generate a DEPENDENCIES.rust.tsv file, Are there any available docs? 👀

Thank you for the PR. This task will be handled by the Release Manager during the release process, so it's not something most contributors need to worry about. However, thanks to @PsiACE's reference, we have a document available at https://opendal.apache.org/community/release/#generate-dependencies-list if you are interested.

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! Overall, this idea seems great.

I've suggested some API-related revisions. I noticed a few issues that could cause compilation failures. How about introducing CI for parquet_opendal right from the start?

integrations/parquet/Cargo.toml Outdated Show resolved Hide resolved
integrations/parquet/src/async_writer.rs Outdated Show resolved Hide resolved
integrations/parquet/src/async_writer.rs Outdated Show resolved Hide resolved
integrations/parquet/src/async_writer.rs Outdated Show resolved Hide resolved
integrations/parquet/src/async_writer.rs Outdated Show resolved Hide resolved
integrations/parquet/src/async_writer.rs Show resolved Hide resolved
integrations/parquet/Cargo.toml Outdated Show resolved Hide resolved
integrations/parquet/Cargo.toml Outdated Show resolved Hide resolved
@Xuanwo Xuanwo changed the title feat: introduce OpendalAsyncWriter for parquet integrations feat: introduce opendal AsyncWriter for parquet integrations Aug 5, 2024
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!

@WenyXu WenyXu merged commit b37191d into apache:main Aug 5, 2024
29 checks passed
ho-229 pushed a commit to ho-229/incubator-opendal that referenced this pull request Aug 6, 2024
…e#4958)

* chore: init parquet crate

* feat: implement the `OpendalAsyncWriter`

* chore: apply suggestions from CR

* chore: remove arrow dep from default

* chore(ci): add ci for opendal_parquet

* test: add test for async writer

* chore: remove arrow dep

* chore(ci): add doc test

* Update .github/workflows/ci_integration_parquet.yml

* chore(ci): run cargo test

---------

Co-authored-by: Xuanwo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants