-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce opendal AsyncWriter
for parquet integrations
#4958
Conversation
BTW, How can I generate a |
https://opendal.apache.org/community/release/#generate-dependencies-list |
Thank you for the PR. This task will be handled by the Release Manager during the release process, so it's not something most contributors need to worry about. However, thanks to @PsiACE's reference, we have a document available at https://opendal.apache.org/community/release/#generate-dependencies-list if you are interested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR! Overall, this idea seems great.
I've suggested some API-related revisions. I noticed a few issues that could cause compilation failures. How about introducing CI for parquet_opendal right from the start?
6c3d08c
to
aa46108
Compare
OpendalAsyncWriter
for parquet integrations AsyncWriter
for parquet integrations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks!
…e#4958) * chore: init parquet crate * feat: implement the `OpendalAsyncWriter` * chore: apply suggestions from CR * chore: remove arrow dep from default * chore(ci): add ci for opendal_parquet * test: add test for async writer * chore: remove arrow dep * chore(ci): add doc test * Update .github/workflows/ci_integration_parquet.yml * chore(ci): run cargo test --------- Co-authored-by: Xuanwo <[email protected]>
Which issue does this PR close?
part of #4868
Rationale for this change
Add parquet arrow async write support
What changes are included in this PR?
parquet_opendal
(integration/parquet) crateOpendalAsyncWriter
Are there any user-facing changes?
No