feat(core)!: make list return path itself #4959
Conversation
|
hi, @Xuanwo I have finished the work for FS and S3, but I’m not sure if the implementation is elegant, especially for S3. Do you have any advice? If you think it’s okay, I’ll continue to complete the others. |
meteorgan
force-pushed
the
list_prefix
branch
2 times, most recently
from
a7cf751
to
e7daee5
Compare
| @@ -146,11 +146,9 @@ impl typed_kv::Adapter for Adapter { | |||
| }; | |||
There was a problem hiding this comment.
this right_range isn't precise, {path}{char::MAX} should include. maybe we should set right bound unbound, and filter by prefix ?
There was a problem hiding this comment.
I'd like to solve it in the next PR. just don't want to add too much work in this one.
ps: this PR is almost done
There was a problem hiding this comment.
Thank you very much for your effort. This issue is truly complex and time-consuming.
Xuanwo
changed the title
|
The HDFS tests seem flaky. In the latest commit, they failed, but the changes aren’t related to them. |
Yes. The ASF download CDN returns 502. Please ignore it. Maybe we can try cache them if you are interested. |
not this one. https://github.com/apache/opendal/actions/runs/10486150908/job/29043772467, here only |
No idea so far. The test and the code seems correct. |
|
Thank you very much for this PR. I will take a review tomorrow. |
|
This PR looks good to me overall. We will merge it after the release of version 0.49.2. |
Which issue does this PR close?
Closes #4877
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?