Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core/services-s3): support user defined metadata #5030

Merged
merged 1 commit into from
Aug 22, 2024
Merged

feat(core/services-s3): support user defined metadata #5030

merged 1 commit into from
Aug 22, 2024

Conversation

haoqixu
Copy link
Contributor

@haoqixu haoqixu commented Aug 22, 2024

Which issue does this PR close?

Support user defined metadata for services-s3.

Part of #4842.

@haoqixu haoqixu force-pushed the main branch 2 times, most recently from 4c75475 to 78bf590 Compare August 22, 2024 06:27
@haoqixu haoqixu marked this pull request as ready for review August 22, 2024 06:38
@haoqixu haoqixu requested a review from Xuanwo as a code owner August 22, 2024 06:38
Xuanwo
Xuanwo reviewed Aug 22, 2024
View reviewed changes
core/Cargo.toml Outdated Show resolved Hide resolved
Xuanwo
Xuanwo reviewed Aug 22, 2024
View reviewed changes
core/src/services/s3/backend.rs Outdated Show resolved Hide resolved
core/src/services/s3/backend.rs Outdated Show resolved Hide resolved
core/src/services/s3/core.rs Outdated Show resolved Hide resolved
core/src/services/s3/core.rs Outdated Show resolved Hide resolved
core/src/services/s3/core.rs Outdated Show resolved Hide resolved
Xuanwo
Xuanwo approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I love simple.

@Xuanwo Xuanwo changed the title feat(services-s3): support user defined metadata feat(core/services-s3): support user defined metadata Aug 22, 2024
@Xuanwo Xuanwo merged commit 61c0546 into apache:main Aug 22, 2024
89 checks passed
@jorgehermo9 jorgehermo9 mentioned this pull request Nov 2, 2024
Merged
@Xuanwo Xuanwo mentioned this pull request Nov 5, 2024
Open
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haoqixu @Xuanwo