Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bindings/c): add writer operation for Bindings C and Go #5141

Merged
merged 5 commits into from
Sep 25, 2024

Conversation

yuchanns
Copy link
Member

@yuchanns yuchanns commented Sep 24, 2024

part of #4892.

  • I changed the test service to fs for maximum full capabilities.
  • Use BlockWriter instead of StdWriter as StdWriter has a limitation of max capacity of buffer to write in for each write operation:
    buf: oio::FlexBuf::new(256 * 1024),
  • Fixed some behavior tests.

Copy link
Contributor

@xyjixyjixyji xyjixyjixyji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the C part is well written. +1 for the C code.

@yuchanns yuchanns force-pushed the feat-c-binding-writer branch 7 times, most recently from 4fc7d5f to 59582c7 Compare September 25, 2024 05:52
@yuchanns yuchanns marked this pull request as ready for review September 25, 2024 07:53
@yuchanns
Copy link
Member Author

Ready for review

@yuchanns yuchanns removed the request for review from Xuanwo September 25, 2024 07:54
@yuchanns yuchanns requested review from Xuanwo and xyjixyjixyji and removed request for PsiACE September 25, 2024 07:54
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for building this @yuchanns, and thanks @xyjixyjixyji's review!

@Xuanwo Xuanwo merged commit 8c78dcf into main Sep 25, 2024
34 checks passed
@Xuanwo Xuanwo deleted the feat-c-binding-writer branch September 25, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants