Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(bindings/cpp): fetch and build dependencies instead of finding system libs #5188

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

PragmaTwice
Copy link
Member

@PragmaTwice PragmaTwice commented Oct 16, 2024

Which issue does this PR close?

Closes #5187.

Rationale for this change

Currently C++ binding uses find_package to locate system-wide libraries like GTest and Boost.

We can replace them by FetchContent to fetch them online and build them by needs (just like cargo) instead of using system libraries (which we cannot control versions and optional features.)

What changes are included in this PR?

  • replace find_package with FetchContent (but still leave a fallback to find_package for dep-reusing purpose)
  • docs for the changes

Are there any user-facing changes?

None.

@PragmaTwice PragmaTwice marked this pull request as ready for review October 16, 2024 10:08
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Xuanwo Xuanwo merged commit f4e1ce7 into apache:main Oct 16, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch and build dependencies instead of finding system libs in C++ binding
2 participants