Remove unused Godeps files; update README for Go Modules #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pritidesai
reviewed
Feb 17, 2021
| $ cd $GOPATH | ||
| $ go get github.com/apache/openwhisk-wskdeploy # see known issues below if you get an error | ||
| $ go get github.com/tools/godep # get the dependency manager | ||
| git clone [email protected]:apache/openwhisk-wskdeploy |
pritidesai
approved these changes
Feb 17, 2021
There was a problem hiding this comment.
Thank you @mrutkows for the detailed and simple instructions on go mod 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Godepsdirectory has not been used since updating the project to use Go Modules. This PR removes that directory structure and any README instructions referencinggo deputility (which is now deprecated). In its place, we are adding instructions on how to build and maintain the project and its dependencies usinggo modandgo getand discussing how contributors should prescriptively update Go module dependencies and be cognizant of using proper versioned releases for releasing this project's source code and binaries.