ORC-1098: [C++] Support specifying type ids or column names in cpp tools #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thank you so much for the PR, @stiga-huang .
Could you review this please, @wgtmac ?
And, if possible, could you participate the on-going Apache ORC 1.6.13 vote, @stiga-huang and @wgtmac ?
|
Thank @dongjoon-hyun! Just voted. |
|
Thank you so much for your participation, @stiga-huang . |
dongjoon-hyun
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
+1, LGTM. Thank you, @stiga-huang .
Merged to main for Apache ORC 1.8.
|
@stiga-huang . After reviewing this PR once more and testing on |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jan 28, 2022
…ols (#1020) ### What changes were proposed in this pull request? This is a follow-up task of #921. Currently we have options for the tools to work on specified top-level column fields. However, ACID ORC files usually have nested structure. We need the type ids to specify nested columns. As an extension, adding support for column names will also be helpful. So we don't need to manually convert column names to type ids. Also reports the valid values when an invalid column name is given. This PR extracts the option parsing codes into ToolsHelper. So similiar cpp tools can share the same option set. ### Why are the changes needed? It makes the tools more useful in practice. ### How was this patch tested? Added unit tests for the new options. (cherry picked from commit 89af2cb) Signed-off-by: Dongjoon Hyun <[email protected]>
cxzl25
pushed a commit
to cxzl25/orc
that referenced
this pull request
Jan 11, 2024
…ols (apache#1020) ### What changes were proposed in this pull request? This is a follow-up task of apache#921. Currently we have options for the tools to work on specified top-level column fields. However, ACID ORC files usually have nested structure. We need the type ids to specify nested columns. As an extension, adding support for column names will also be helpful. So we don't need to manually convert column names to type ids. Also reports the valid values when an invalid column name is given. This PR extracts the option parsing codes into ToolsHelper. So similiar cpp tools can share the same option set. ### Why are the changes needed? It makes the tools more useful in practice. ### How was this patch tested? Added unit tests for the new options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up task of #921. Currently we have options for the tools to work on specified top-level column fields. However, ACID ORC files usually have nested structure. We need the type ids to specify nested columns. As an extension, adding support for column names will also be helpful. So we don't need to manually convert column names to type ids. Also reports the valid values when an invalid column name is given.
This PR extracts the option parsing codes into ToolsHelper. So similiar cpp tools can share the same option set.
Why are the changes needed?
It makes the tools more useful in practice.
How was this patch tested?
Added unit tests for the new options.