Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORC-1108: Use RawLocalFileSystem to skip checksum files during benchmark data generation #1034

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

williamhyun
Copy link
Member

What changes were proposed in this pull request?

This PR aims to use RawLocalFileSystem to skip checksum files during benchmark data generation.

Why are the changes needed?

There is no need to check for checksums.

How was this patch tested?

Manually.

@github-actions github-actions bot added the JAVA label Jan 31, 2022
@williamhyun williamhyun changed the title ORC-1108: Use RawLocalFileSystem to skip checksum files during benchmark data generation ORC-1108: Use RawLocalFileSystem to skip checksum files during benchmark data generation Jan 31, 2022
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Ya, this looks reasonable because we don't benchmark the data generation time and we don't use the checksum.

@dongjoon-hyun dongjoon-hyun merged commit 9dfafce into apache:main Jan 31, 2022
@dongjoon-hyun dongjoon-hyun added this to the 1.7.3 milestone Jan 31, 2022
dongjoon-hyun pushed a commit that referenced this pull request Jan 31, 2022
…hmark data generation (#1034)

### What changes were proposed in this pull request?

This PR aims to use `RawLocalFileSystem` to skip checksum files during benchmark data generation.

### Why are the changes needed?

There is no need to check for checksums.

### How was this patch tested?

Manually.

(cherry picked from commit 9dfafce)
Signed-off-by: Dongjoon Hyun <[email protected]>
@dongjoon-hyun
Copy link
Member

BTW, I backported this to branch-1.7 too.

cxzl25 pushed a commit to cxzl25/orc that referenced this pull request Jan 11, 2024
…hmark data generation (apache#1034)

### What changes were proposed in this pull request?

This PR aims to use `RawLocalFileSystem` to skip checksum files during benchmark data generation. 

### Why are the changes needed?

There is no need to check for checksums. 

### How was this patch tested?

Manually.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants