ORC-1109: Use zstd instead of none in the default compress option #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
approved these changes
Jan 31, 2022
There was a problem hiding this comment.
+1, I agree with you that the none's portion of generated data size is too big, @williamhyun .
Since we still generates none if we give the option explicitly, it looks reasonable to me.
Merged to main/1.7.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jan 31, 2022
…#1035) ### What changes were proposed in this pull request? This PR aims to use `zstd` instead of `none` in the default compress option. ### Why are the changes needed? This will reduce the hardware requirements for running benchmark. ``` $ du -h * | sort -nr 112G github 67G sales 21G taxi ``` ``` $ du -h */*none | sort -nr 663M taxi/parquet.none 28G github/json.none 22G sales/json.none 18G github/avro.none 14G github/parquet.none 12G github/orc.none 10G taxi/json.none 4.9G sales/avro.none 4.2G sales/parquet.none 2.9G sales/orc.none 2.0G taxi/avro.none 1.2G taxi/orc.none ``` ### How was this patch tested? Manually generate benchmark data. (cherry picked from commit bcfa71e) Signed-off-by: Dongjoon Hyun <[email protected]>
|
I tested on the master branch again and noticed that the generated data folder is almost |
cxzl25
pushed a commit
to cxzl25/orc
that referenced
this pull request
Jan 11, 2024
…apache#1035) ### What changes were proposed in this pull request? This PR aims to use `zstd` instead of `none` in the default compress option. ### Why are the changes needed? This will reduce the hardware requirements for running benchmark. ``` $ du -h * | sort -nr 112G github 67G sales 21G taxi ``` ``` $ du -h */*none | sort -nr 663M taxi/parquet.none 28G github/json.none 22G sales/json.none 18G github/avro.none 14G github/parquet.none 12G github/orc.none 10G taxi/json.none 4.9G sales/avro.none 4.2G sales/parquet.none 2.9G sales/orc.none 2.0G taxi/avro.none 1.2G taxi/orc.none ``` ### How was this patch tested? Manually generate benchmark data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to use
zstdinstead ofnonein the default compress option.Why are the changes needed?
This will reduce the hardware requirements for running benchmark.
How was this patch tested?
Manually generate benchmark data.