Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORC-1120: Remove C++ library limitation about write version #1054

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

XinyuZeng
Copy link
Contributor

What changes were proposed in this pull request?

Delete the content in README.md which states the cpp writer only writes 0.11 version.

Why are the changes needed?

Inconsistency between doc and code.

How was this patch tested?

Manually check the README.md file under root directory.

@dongjoon-hyun
Copy link
Member

cc @wgtmac and @stiga-huang

@dongjoon-hyun dongjoon-hyun changed the title ORC-1120: fix readme about cpp orc version ORC-1120: Remove C++ library limitation about write version Mar 4, 2022
@dongjoon-hyun dongjoon-hyun merged commit 93e69fd into apache:main Mar 4, 2022
@dongjoon-hyun dongjoon-hyun added this to the 1.8.0 milestone Mar 4, 2022
@dongjoon-hyun
Copy link
Member

Welcome to the Apache ORC community, @XinyuZeng .
I added you to the Apache ORC contributor group and assign ORC-1120 to you.

@dongjoon-hyun dongjoon-hyun modified the milestones: 1.8.0, 1.7.4 Mar 4, 2022
dongjoon-hyun pushed a commit that referenced this pull request Mar 4, 2022
### What changes were proposed in this pull request?

Delete the content in README.md which states the cpp writer only writes 0.11 version.

### Why are the changes needed?

Inconsistency between doc and code.

### How was this patch tested?

Manually check the README.md file under root directory.

(cherry picked from commit 93e69fd)
Signed-off-by: Dongjoon Hyun <[email protected]>
@dongjoon-hyun
Copy link
Member

This is backported to branch-1.7.

cc @williamhyun

cxzl25 pushed a commit to cxzl25/orc that referenced this pull request Jan 11, 2024
)

### What changes were proposed in this pull request?

Delete the content in README.md which states the cpp writer only writes 0.11 version.

### Why are the changes needed?

Inconsistency between doc and code.

### How was this patch tested?

Manually check the README.md file under root directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants